Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trial Labels During Pod Mutation #2047

Merged

Conversation

andreyvelich
Copy link
Member

As we discussed on the recent AutoML WG meeting, we should add Trial labels to the pod during mutation.
We need it to get Trial logs from the Katib UI backend: #2039.

cc @kimwnasptd @johnugeorge @tenzen-y @d-gol

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Thanks for this work! This feature makes helpful users!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 2, 2022
@google-oss-prow google-oss-prow bot merged commit dc24278 into kubeflow:master Dec 2, 2022
@andreyvelich andreyvelich deleted the add-label-to-trial-pods branch December 5, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants